Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latitude and longitude mapping issue for version 5.0 #632

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

yhhongyang
Copy link
Contributor

According to neo4j PointValue document, x represent longitude and y represent latitude

Change the mapping of latitude and longitude

@yhhongyang yhhongyang requested a review from a team as a code owner June 28, 2024 07:40
@fbiville
Copy link
Contributor

fbiville commented Jul 8, 2024

Hello, thanks for your contribution!
Before we proceed, can you please sign Neo4j's CLA?

@yhhongyang
Copy link
Contributor Author

@fbiville I have sent the email with Neo4j CLA, if there is anything else that is required, please let me know, thanks.

@fbiville
Copy link
Contributor

fbiville commented Jul 9, 2024

@yhhongyang 2 questions:

  • you signed the CLA document meant for IBM workers: do you work for IBM? If not, you need to pick the other one.
  • your commit's email address does not match the email address you mention in the email you sent for CLA approval. Can you please either reply by mentioning the commit's email or amend your commit with the email address mentioned in CLA email?

Thanks a lot!

@yhhongyang
Copy link
Contributor Author

@fbiville For your 2 questions

  1. Yes, I work for IBM.
  2. I resend the email, and change the email address with the one that I used to commit code, could you please check again, thanks.

@fbiville
Copy link
Contributor

@yhhongyang thanks but the emails still don't match

@fbiville
Copy link
Contributor

@yhhongyang could you maybe send the CLA and amend the commit with your IBM email address? thanks!

@yhhongyang
Copy link
Contributor Author

@fbiville I checked the email I sent earlier and found the problem and fixed it. Could you please check it again? Thanks

@fbiville
Copy link
Contributor

@yhhongyang thanks! can you also please send the signed CLA with that email address please?

@yhhongyang
Copy link
Contributor Author

I think I sent that in 07/16
image

@fbiville
Copy link
Contributor

I know you sent it but as I tried to say multiple times: the commit email and the email you use and mention for the CLA need to match.
Now that you amended your commit with your IBM email address, can you please also use and mention the very same IBM email address with the signed CLA?

@yhhongyang
Copy link
Contributor Author

Did I send it right this time?

@fbiville
Copy link
Contributor

Did I send it right this time?

Yes, thanks!

Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yhhongyang.

@ali-ince ali-ince merged commit 6fa0a0b into neo4j-contrib:5.0 Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants